Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the SDK conversion from address to identifier. #149

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Oct 11, 2022

What

Use the SDK conversion from address to identifier.

I"m ok with postponing this if we don"t want to bump the SDK revision, this is mostly to not forget about the change.

Why

Simplifying example code

Known limitations

N/A

@leighmcculloch leighmcculloch merged commit 72101a2 into stellar:main Oct 11, 2022
@leighmcculloch
Copy link
Member

I"m ok with postponing this if we don"t want to bump the SDK revision, this is mostly to not forget about the change.

Let"s merge it. If we need to tag a new release, we can figure it out. The examples referenced by the docs reference a tag on this repo too fyi.

leighmcculloch added a commit that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants