Simplified auth in timelock example. #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the example just uses invoker auth.
leighmcculloch
approved these changes
Oct 11, 2022
Comment on lines
-10
to
+17
| use soroban_auth::{ | ||
| verify, {Identifier, Signature}, | ||
| }; | ||
| use soroban_sdk::{contractimpl, contracttype, BigInt, BytesN, Env, Symbol, Vec}; | ||
| use soroban_sdk::{contractimpl, contracttype, Address, BigInt, BytesN, Env, Vec}; | ||
|
|
||
| mod token { | ||
| soroban_sdk::contractimport!(file = "../soroban_token_spec.wasm"); | ||
| } | ||
|
|
||
| use token::{Identifier, Signature}; |
There was a problem hiding this comment.
Fyi it"s also still fine to use soroban_auth::Identifier and Signature, as the token versions are just type aliases to them. It"s also fine to do what this change does, just FYI in case they were understood to be different types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Now the example only uses invoker auth.
Why
As discussed in #146, the auth is not that relevant for this example,
Known limitations
N/A