Rewrite the auth example to be based on the increment example #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sisuresh Wdyt of this? If you think this is good I"d like to also update the advanced auth example so it does auth for incrementing a value, but as features on the incremental example. I"d probably remove the admin feature and just make it so there"s a user who is authenticated. Here"s what the docs will look like once updated: |
6 tasks
|
Yeah I think this makes sense, and the docs for this look great. Thanks! |
sisuresh
approved these changes
Oct 8, 2022
|
Thanks for reviewing. I"ll do the same to the advanced auth example too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rewrite the auth example to be based on the increment example
Why
So that all the smaller examples are similar and tell a story for how to add a feature to a contract. This was a suggestion from @tomerweller. I"ve tried it on a few examples and it seems to work pretty well I think.