With seed as cli parameter #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me! |
|
👍 I'll test this, make necessary corrections and update this PR. |
This parameter makes the non-AFL (quickcheck) tests deterministic.
This parameter sets the number of repetition for non-AFL (quickcheck) tests.
|
Good news: the seed flag works. I also added a It's not quite redundant with the infinity mode, but it's also not orthogonal. So I'm happy to either remove it, merge both options into a single option (maybe By the way, I found out that it works by finding that the |
raphael-proust
force-pushed
the
with-seed-as-cli-parameter
branch
from
146df13 to
f5694c6
Compare
|
bump |
|
ping |
|
Merged! Thanks, and apologies for forgetting about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CLI parameter (
-s/--seed) to make the quickcheck mode fully deterministic.Note that the current state is mostly deterministic: two consecutive runs derive the same original seed from the global
RandomPRNG. However, linked libraries can change the PRNG state:Random.self_initwhich makes the tests non-deterministic.Random.int, changing the determinism.This PR is not yet tested. I wanted to get a quick mood check before putting significant effort in: Is this change or one like it likely to be merged? Is there interest for such a feature? Any comments on the user interface?