[5.x] Add always_augment_to_query option
#11086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksleight
changed the title
always_augment_to_query optionalways_augment_to_query option
Yup.
There's probably a way. But since this behavior is opt-in and not breaking, we could always update the parser to support this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #9979 (maybe), see #9979 (review).
This PR adds an
always_augment_to_queryoption that when enabled ensures that relationship fields always augment to a query builder, instead of the current behaviour where single (max_items: 1) relationships return the related entry.The main reason to do this is to make the API more consistent and allow altering the single relationship queries (which are limited to published entries only by default). But unfortunately it does have other side effects as this will no longer work:
{{ product:title }}Instead you have to do this:
{{ product }}{{ title }}{{ /product }}I'm guessing this may be the reason for the original behaviour in the first place?
Ideally the first method should still work, I don't know if there's a way to get the antlers parser to figure it out and run the query if a property name has been appended?
If this is merged it shouldn't be breaking as it's opt-in.