Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

occurredAt instead of timestamp #164

Open
iosifch opened this issue Jun 26, 2024 · 0 comments
Open

occurredAt instead of timestamp #164

iosifch opened this issue Jun 26, 2024 · 0 comments

Comments

@iosifch
Copy link

iosifch commented Jun 26, 2024

Hi!
The Payload structure section says the payload must contain a "timestamp" field that should describe the time when the event occurred. I suggest we use "occurredAt" instead because "timestamp" is a bit fuzzy and it may have different meanings.

So, the payload would look like:

{
  "type": "example.event",
  "occurredAt": "2022-11-03T20:26:10.344522Z",
  "data": {
    "foo": "bar",
    "fizzbuzz": 2
  }
}

What do you think? If you're ok with this change then I could come back with a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant