Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of identifier requirement of App protocol #89

Closed
stackotter opened this issue Apr 9, 2024 · 3 comments
Closed

Get rid of identifier requirement of App protocol #89

stackotter opened this issue Apr 9, 2024 · 3 comments
Labels
API enhancement New feature or request

Comments

@stackotter
Copy link
Owner

The identifier property is only used by Gtk so I reckon GtkBackend should just use a default value and provide some way to configure it. Alternatively, we could just provide a default implementation of the identifier property which has some default identifier such as com.example.Example (not sure what a good default would be).

@stackotter stackotter added enhancement New feature or request API labels Apr 9, 2024
@warmachinesocial
Copy link

Did you mean this under GtkBackend.swift

    public typealias Window = Gtk.Window
    public typealias Widget = Gtk.Widget

    var gtkApp: Application

    /// A window to be returned on the next call to ``GtkBackend/createWindow``.
    /// This is necessary because Gtk creates a root window no matter what, and
    /// this needs to be returned on the first call to `createWindow`.
    var precreatedWindow: Window?

    public init(appIdentifier: String) {
        gtkApp = Application(applicationId: appIdentifier)
    }

@stackotter
Copy link
Owner Author

Yeah, that initialiser is currently the only piece of code that actually uses the appIdentifier for anything, the other backends just ignore it, so it should be a gtk specific setting instead of a setting provided to all backends.

@stackotter
Copy link
Owner Author

Completed this on the layout_system branch a little while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants