-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of identifier
requirement of App
protocol
#89
Labels
Comments
Did you mean this under GtkBackend.swift
|
Yeah, that initialiser is currently the only piece of code that actually uses the appIdentifier for anything, the other backends just ignore it, so it should be a gtk specific setting instead of a setting provided to all backends. |
Completed this on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
identifier
property is only used by Gtk so I reckonGtkBackend
should just use a default value and provide some way to configure it. Alternatively, we could just provide a default implementation of theidentifier
property which has some default identifier such ascom.example.Example
(not sure what a good default would be).The text was updated successfully, but these errors were encountered: