Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace test.com with special-use domain name. #769

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

guidorice
Copy link
Contributor

@guidorice guidorice commented Mar 18, 2022

Related Issue(s): #

Fixes #732

Description:

Use stac.test instead of test.com, following https://www.rfc-editor.org/rfc/rfc6761.html

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb requested a review from schwehr March 30, 2022 19:36
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #769 (3ab25f2) into main (037fd73) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #769    /-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files          79       79           
  Lines       11647    11647           
  Branches     1372     1372           
=======================================
  Hits        11013    11013           
  Misses        455      455           
  Partials      179      179           
Impacted Files Coverage Δ
tests/test_catalog.py 99.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 037fd73...3ab25f2. Read the comment docs.

@duckontheweb duckontheweb merged commit d5c597d into stac-utils:main Mar 31, 2022
@guidorice guidorice deleted the fix/732-special-use-domains branch March 31, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a proper domain for testing - example.org or example.com
4 participants