No issues from me.

Only minor comment is that Union[str, "os.PathLike[AnyStr]"] ends up everywhere and is a lot to parse for a casual reader, is it worth type aliasing that to Href or something?

Yeah, I agree that's pretty hard to interpret. Maybe we should have a types.py module where we can keep some PySTAC-/STAC-specific types that we use throughout the library.

Looks good to me to.

I vaguely recall a discussion around whether __fspath__ was intended to represent a "proper" filesystem, or whether it could be used for potentially remote urls like we're doing here for Links. But IMO it's ok. If you do something like open(item.links[0]), where the link happens to be remote, you're still going to get an error.

No issues from me.
Only minor comment is that Union[str, "os.PathLike[AnyStr]"] ends up everywhere and is a lot to parse for a casual reader, is it worth type aliasing that to Href or something?

Yeah, I agree that's pretty hard to interpret. Maybe we should have a types.py module where we can keep some PySTAC-/STAC-specific types that we use throughout the library.

I created a pystac.types module that currently has the HREF type alias (from this PR) and the ItemLike type alias that used to be in pystac.item_collection. I think we could probably do some more work on creating more readable type aliases and moving them into pystac.types, but that seems better left for a separate PR.

@l0b0 Do you have any thoughts on the approach of storing type aliases in a single module?

@l0b0 Do you have any thoughts on the approach of storing type aliases in a single module?

I'd treat that the same as utility functions, and refer to my answer to Is putting general-use functions in a "helpers" file an anti-pattern or code smell? 😁

@l0b0 Do you have any thoughts on the approach of storing type aliases in a single module?

I'd treat that the same as utility functions, and refer to my answer to Is putting general-use functions in a "helpers" file an anti-pattern or code smell? 😁

Thanks. It does feel like overkill to create a separate types sub-module for just 2 type aliases, especially since 1 of them is only used by the ItemCollection class. I'm going to move ItemLike back where it came from and put HREF into the link sub-module since that seems like the most logical place for it.

Codecov Report

Merging #728 (3e9da85) into main (4b30217) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #728       /-   ##
==========================================
  Coverage   94.33%   94.39%    0.05%     
==========================================
  Files          77       77              
  Lines       11285    11292        7     
  Branches     1347     1343       -4     
==========================================
  Hits        10646    10659       13     
  Misses        459      455       -4     
  Partials      180      178       -2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b30217...3e9da85. Read the comment docs.