Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Satellite Extension #509

Merged
merged 6 commits into from
Jul 7, 2021
Merged

Update Satellite Extension #509

merged 6 commits into from
Jul 7, 2021

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jul 1, 2021 •
edited
Loading

Related Issue(s): #

Description:

  • Adds missing fields to Satellite Extension
  • Implements collection summaries for Satellite Extension
  • Defines __eq__ and __repr__ for RangeSummary
    I found myself wanting to use this when testing summaries

Let me know what you think about the implementation of the RangeSummary for the sat:anx_datetime field, which has a datetime type.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb
Copy link
Contributor Author

cc: @jonas-eberle

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2021 •
edited
Loading

Codecov Report

Merging #509 (9a972d8) into main (27d6132) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #509       /-   ##
==========================================
  Coverage   94.07%   94.18%    0.10%     
==========================================
  Files          71       71              
  Lines       10133    10276      143     
  Branches     1067     1069        2     
==========================================
  Hits         9533     9678      145     
  Misses        432      430       -2     
  Partials      168      168
Impacted Files Coverage Δ
pystac/extensions/sat.py 100.00% <100.00%> ( 3.07%) ⬆️
tests/extensions/test_sat.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d6132...9a972d8. Read the comment docs.

@duckontheweb duckontheweb mentioned this pull request Jul 3, 2021
Merged
5 tasks
@lossyrob
Copy link
Member

lossyrob commented Jul 7, 2021

RangeSummary for the datetime LGTM

@duckontheweb duckontheweb force-pushed the update/sat-extension branch from eed30aa to 9a972d8 Compare July 7, 2021 12:02
@duckontheweb duckontheweb merged commit a0f79a3 into stac-utils:main Jul 7, 2021
@duckontheweb duckontheweb deleted the update/sat-extension branch July 7, 2021 20:14
This was referenced Jul 14, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lossyrob lossyrob lossyrob approved these changes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sat extension update
3 participants
@duckontheweb @codecov-commenter @lossyrob