Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against Python 3.9 #420

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Test against Python 3.9 #420

merged 1 commit into from
Jun 15, 2021

Conversation

duckontheweb
Copy link
Contributor

Description:

Expands CI test matrix to include Python 3.9 and 3.10. Python 3.10 is marked as "experimental", so the CI workflow will still succeed even if that job fails.

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb changed the title [WIP] Test against Python 3.9 and 3.10 (experimentally) Test against Python 3.9 and 3.10 (experimentally) Jun 8, 2021
@duckontheweb duckontheweb marked this pull request as ready for review June 8, 2021 18:39
@duckontheweb
Copy link
Contributor Author

This is currently failing because of the bump to orjson==3.5.3. That version does not yet have a wheel for Python 3.10 and building from source requires the nightly version of Rust, which is not configured for this environment. The orjson maintainers seem to be good about creating these wheels (they exists for 3.5.2 on Python 3.10), so we should just wait for those to be available.

@l0b0
Copy link
Contributor

l0b0 commented Jun 14, 2021

Looks good! How about introducing 3.9 and 3.10 support in separate PRs?

@duckontheweb duckontheweb changed the title Test against Python 3.9 and 3.10 (experimentally) Test against Python 3.9 Jun 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021 •
edited
Loading

Codecov Report

Merging #420 (4ee2a5d) into main (46fbaa7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #420    /-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          40       40           
  Lines        5150     5150           
=======================================
  Hits         4623     4623           
  Misses        527      527

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46fbaa7...4ee2a5d. Read the comment docs.

@duckontheweb
Copy link
Contributor Author

How about introducing 3.9 and 3.10 support in separate PRs?

Good call. I updated this PR to focus on 3.9 and will open a separate PR for testing 3.10.

@duckontheweb duckontheweb requested a review from lossyrob June 15, 2021 01:29
@l0b0 l0b0 mentioned this pull request Jun 15, 2021
Closed
@duckontheweb duckontheweb merged commit cfff3c5 into stac-utils:main Jun 15, 2021
@duckontheweb duckontheweb deleted the change/test-3.9 branch June 15, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lossyrob lossyrob lossyrob approved these changes

@l0b0 l0b0 l0b0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@duckontheweb @l0b0 @codecov-commenter @lossyrob