handle optional arguments in View Extension #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow for optional arguments in apply - raise error if all arguments are None
This reverts commit fb566fc.
Codecov Report
@@ Coverage Diff @@
## develop #259 /- ##
===========================================
Coverage 94.00% 94.01% 0.01%
===========================================
Files 32 32
Lines 3969 3978 9
===========================================
Hits 3731 3740 9
Misses 238 238
Continue to review full report at Codecov.
|
tyler-c2s
changed the title
|
Thanks! Would you mind updating the CHANGELOG.md with this change? This will be the first unreleased addition, so if you could add a |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #258, in which parameters that were not passed to the
.apply()method in the view extension would result in validation issues.Updated: