add timestamps extension #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That seems correct to me. I would expect that if |
lossyrob
requested changes
Aug 18, 2020
|
Also note that you should add a CHANGELOG entry for this. Thanks! |
|
Should have mentioned this before, but can you add an |
|
sure, will do |
lossyrob
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
timestampsextensioncloses #135
One question I have is about the
applymethod inTimestampsItemExt(and this question could be relevant to other extensions as well): if you pass null values for optional arguments defining properties that are already defined in that item, should the null value override the existing property?So for example:
itemalready haspublishedandexpireddefined.if i do
item.ext.timestamps.apply(unpublished=d), this will convert those other two properties to None. Should this be the case?