Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize css a bit and make it better at overriding jupyter defaults #1311

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Minimize css a bit and make it better at overriding jupyter defaults #1311

merged 1 commit into from
Feb 21, 2024

Conversation

jsignell
Copy link
Member

Related Issue(s):

Description:

Kind of hard to reproduce, but even if this is a noop in many cases the reduction in size will hopefully be compelling.

For a notebook containing an executed version of the following:

search = client.search(
    max_items=10,
    collections=['sentinel-2-l2a'],
    bbox=[-72.5,40.5,-72,41]
)
search.item_collection()

image

The saved size on this branch is 4.4M as opposed to 5.4M on main

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (679eaff) 91.18% compared to head (605cc45) 91.18%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1311    /-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          51       51           
  Lines        7023     7023           
  Branches     1005     1005           
=======================================
  Hits         6404     6404           
  Misses        444      444           
  Partials      175      175

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsignell
Copy link
Member Author

I just confirmed that this resolves this issue in the jupyterhub where I originally encountered it:

image

@gadomski gadomski added this pull request to the merge queue Feb 21, 2024
@gadomski gadomski linked an issue Feb 21, 2024 that may be closed by this pull request
HTML repr is sometimes missing dropdown icon #1310
Closed
Merged via the queue into stac-utils:main with commit 717cb1b Feb 21, 2024
20 checks passed
@jsignell jsignell deleted the html-repr branch February 22, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML repr is sometimes missing dropdown icon
2 participants
@jsignell @gadomski