Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension version migrations #1258

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Add extension version migrations #1258

merged 6 commits into from
Oct 12, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Oct 10, 2023 •
edited
Loading

Related Issue(s):

Description:

These are the easy fixes to support extension migrations, along with some tests. #1228 contains links to other issues to capture larger fixes, e.g. new extension versions.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell October 10, 2023 14:36
@gadomski gadomski self-assigned this Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pystac/extensions/datacube.py 80.06% <100.00%> (ø)
pystac/extensions/table.py 72.90% <100.00%> (ø)
pystac/extensions/timestamps.py 100.00% <100.00%> (ø)
pystac/extensions/classification.py 95.01% <75.00%> (-1.02%) ⬇️

📢 Thoughts on this report? Let us know!.

jsignell
jsignell approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful!

tests/extensions/test_datacube.py Show resolved Hide resolved
@gadomski gadomski added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 04c8ee1 Oct 12, 2023
18 checks passed
@gadomski gadomski deleted the issues/1228-extension-audit branch October 12, 2023 15:41
jsignell added a commit to jsignell/pystac that referenced this pull request Oct 17, 2023
@jsignell
Align with stac-utils#1264 and stac-utils#1258
f85726b
github-merge-queue bot pushed a commit that referenced this pull request Oct 17, 2023
@jsignell @gadomski
Update file extension and add Link.ext (#1265)
d7a6712 
* Update file extension, add Link.ext, let file apply to catalogs

* Recreate all cassettes for test_file

* Missed some cassettes

* Let objects use v1.0.0 of file ext, but warn them if old fields present

* Align with #1264 and #1258

---------

Co-authored-by: Pete Gadomski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @jsignell