Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the pre-compiled version regex #1241

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Use the pre-compiled version regex #1241

merged 1 commit into from
Sep 28, 2023

Conversation

gadomski
Copy link
Member

Related Issue(s):

Description:

Sorry should have caught this during review 🙇🏼, doesn't need a changelog

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell September 27, 2023 20:17
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
pystac/extensions/base.py 92.30% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@gadomski gadomski marked this pull request as ready for review September 28, 2023 13:04
@gadomski gadomski added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 2dab105 Sep 28, 2023
22 checks passed
@gadomski gadomski deleted the fix-extension-regex-split branch September 28, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @jsignell