Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mypy config to pyproject.toml #1240

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Move mypy config to pyproject.toml #1240

merged 1 commit into from
Sep 28, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Sep 27, 2023 •
edited
Loading

Description:

For some reason this exposed a type error 🤷?

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell September 27, 2023 20:03
@gadomski gadomski self-assigned this Sep 27, 2023
@gadomski gadomski force-pushed the mypy-config-to-pyproject.toml branch from 932e244 to f6105dd Compare September 27, 2023 20:04
@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@gadomski gadomski enabled auto-merge September 27, 2023 20:09
@gadomski gadomski mentioned this pull request Sep 27, 2023
Merged
5 tasks
jsignell
jsignell approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gadomski gadomski added this pull request to the merge queue Sep 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 28, 2023
@gadomski
chore: move mypy config to pyproject.toml
495884f 
For some reason this exposed a type error 🤷?
@gadomski gadomski force-pushed the mypy-config-to-pyproject.toml branch from f6105dd to 495884f Compare September 28, 2023 13:16
@gadomski gadomski enabled auto-merge September 28, 2023 13:16
@gadomski gadomski added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 1e2f3db Sep 28, 2023
22 checks passed
@gadomski gadomski deleted the mypy-config-to-pyproject.toml branch September 28, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
No open projects
STAC Sprint 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @jsignell