Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop python 3.8 #1236

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Drop python 3.8 #1236

merged 3 commits into from
Sep 28, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Sep 27, 2023 •
edited
Loading

Related Issue(s):

Description:

I did not run pyupgrade as that'll be really noisy, so I'm going to wait until the sprint is over and the repo has fewer folks hacking on it. I've opened a ticket to track that: #1235.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.
  • (when approved) Remove the required Python 3.8 Github Actions checks

@gadomski gadomski requested a review from jsignell September 27, 2023 16:28
@gadomski gadomski force-pushed the issues/1148-drop-python-3.8 branch from 90e1234 to 29d57d2 Compare September 27, 2023 16:29
@gadomski
chore: drop python 3.8
f5c43d0 
I did _not_ run **pyupgrade** as that'll be really noisy, so I'm going to wait
until the sprint is over and the repo has fewer folks hacking on it.
@gadomski gadomski force-pushed the issues/1148-drop-python-3.8 branch from 29d57d2 to f5c43d0 Compare September 27, 2023 16:31
@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
pystac/summaries.py 78.49% <100.00%> ( 0.71%) ⬆️
pystac/validation/local_validator.py 59.57% <100.00%> ( 1.57%) ⬆️

📢 Thoughts on this report? Let us know!.

jsignell
jsignell approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Probably need to update the conda-forge recipe as well.

@gadomski
Copy link
Member Author

Probably need to update the conda-forge recipe as well.

I think they auto-open a PR 🤞🏼

@gadomski gadomski enabled auto-merge September 28, 2023 13:14
@gadomski gadomski added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 6f00acf Sep 28, 2023
18 checks passed
@gadomski gadomski deleted the issues/1148-drop-python-3.8 branch September 28, 2023 13:28
@gadomski gadomski mentioned this pull request Sep 28, 2023
Merged
5 tasks
@gadomski gadomski mentioned this pull request Apr 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.8
2 participants
@gadomski @jsignell