Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include fields-normalized.json in build #1188

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Include fields-normalized.json in build #1188

merged 2 commits into from
Jul 12, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jul 10, 2023 •
edited
Loading

Related Issue(s):

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski added this to the 1.8.2 milestone Jul 10, 2023
@gadomski gadomski requested review from jsignell and pjhartzell July 10, 2023 13:08
@gadomski gadomski self-assigned this Jul 10, 2023
@gadomski gadomski requested a review from vincentsarago July 12, 2023 17:59
@gadomski
Copy link
Member Author

@vincentsarago would you mind taking a look at this? I'd like to get a v1.8.2 out so we can pick up #1189.

@gadomski gadomski enabled auto-merge July 12, 2023 18:05
@vincentsarago
Copy link
Member

LGTM ✨

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bac884e) 92.01% compared to head (c60d651) 92.01%.

❗ Current head c60d651 differs from pull request most recent head 5f410d6. Consider uploading reports for the commit 5f410d6 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1188    /-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          51       51           
  Lines        6809     6809           
  Branches     1007     1007           
=======================================
  Hits         6265     6265           
  Misses        368      368           
  Partials      176      176

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski added this pull request to the merge queue Jul 12, 2023
Merged via the queue into main with commit 5ef8cf3 Jul 12, 2023
@gadomski gadomski deleted the manifest-fields branch July 12, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsarago vincentsarago vincentsarago approved these changes

@jsignell jsignell Awaiting requested review from jsignell

@pjhartzell pjhartzell Awaiting requested review from pjhartzell

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
1.8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @vincentsarago