Collection link should be resolved with root #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
force-pushed
the
resolve-collection-with-root
branch
from
4155939 to
2164af1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1171 /- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 51 51
Lines 6792 6792
Branches 1000 1000
=======================================
Hits 6248 6248
Misses 368 368
Partials 176 176
☔ View full report in Codecov by Sentry. |
gadomski
added a commit
to stac-utils/pystac-client
that referenced
this pull request
Jun 23, 2023
Couple of things going on here: - Without stac-utils/pystac#1171, the resolved collection won't have a root. - Even with stac-utils/pystac#1171, the root will be cast to a `Catalog` by https://github.com/stac-utils/pystac/blob/9b363db07f19692d319804ccffce23b72d759839/pystac/stac_object.py#L275-L292, so this assertion would fail even with the preserve_dict To fix breakages to existing code, we remove the assertion, and assume that stuff will blow up later if the `root` isn't the correct object type.
3 tasks
gadomski
added a commit
to stac-utils/pystac-client
that referenced
this pull request
Jun 23, 2023
Couple of things going on here: - Without stac-utils/pystac#1171, the resolved collection won't have a root. - Even with stac-utils/pystac#1171, the root will be cast to a `Catalog` by https://github.com/stac-utils/pystac/blob/9b363db07f19692d319804ccffce23b72d759839/pystac/stac_object.py#L275-L292, so this assertion would fail even with the preserve_dict To fix breakages to existing code, we remove the assertion, and assume that stuff will blow up later if the `root` isn't the correct object type.
gadomski
added a commit
to stac-utils/pystac-client
that referenced
this pull request
Jun 23, 2023
Couple of things going on here: - Without stac-utils/pystac#1171, the resolved collection won't have a root. - Even with stac-utils/pystac#1171, the root will be cast to a `Catalog` by https://github.com/stac-utils/pystac/blob/9b363db07f19692d319804ccffce23b72d759839/pystac/stac_object.py#L275-L292, so this assertion would fail even with the preserve_dict To fix breakages to existing code, we remove the assertion, and assume that stuff will blow up later if the `root` isn't the correct object type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
AssertionErrorinstac_object_from_dictwhen callingitem.get_collection()in 0.7.1 pystac-client#548Description:
When resolving an item's collection link, we should pass the item's root into
resolve_stac_object. This situation can come up when bouncing around a STAC API, where you don't always have a full tree built up in your cache.PR Checklist:
pre-commithooks pass locallyscripts/test)