Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include some json schemas within pystac #1165

Merged
merged 7 commits into from
Jun 21, 2023
Merged

Include some json schemas within pystac #1165

merged 7 commits into from
Jun 21, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Jun 16, 2023 •
edited
Loading

Related Issue(s):

Description:

I pulled a lot of @gadomski's work off the v2 branch, but left the existing validation mechanism in place, just calling out to the new stuff when the schema is local.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov
Copy link

codecov bot commented Jun 16, 2023 •
edited
Loading

Codecov Report

Patch coverage: 91.89% and project coverage change: 0.02 🎉

Comparison is base (c871b36) 92.03% compared to head (fbd3be4) 92.06%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1165       /-   ##
==========================================
  Coverage   92.03%   92.06%    0.02%     
==========================================
  Files          49       50        1     
  Lines        6658     6708       50     
  Branches      984      990        6     
==========================================
  Hits         6128     6176       48     
- Misses        356      357        1     
- Partials      174      175        1
Impacted Files Coverage Δ
pystac/validation/stac_validator.py 80.00% <85.71%> ( 0.87%) ⬆️
pystac/validation/local_validator.py 95.55% <95.55%> (ø)
pystac/errors.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsignell jsignell marked this pull request as ready for review June 16, 2023 20:16
@jsignell jsignell requested a review from gadomski June 16, 2023 20:16
@jsignell jsignell self-assigned this Jun 16, 2023
@jsignell jsignell requested a review from gadomski June 20, 2023 14:38
@jsignell jsignell added this pull request to the merge queue Jun 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 21, 2023
@jsignell jsignell added this pull request to the merge queue Jun 21, 2023
@jsignell
Copy link
Member Author

Oh rats. merge queue is never going to work with that failing schema lookup

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 21, 2023
@jsignell jsignell added this pull request to the merge queue Jun 21, 2023
Merged via the queue into stac-utils:main with commit b9991b2 Jun 21, 2023
@jsignell jsignell deleted the validation-reorg branch June 21, 2023 20:41
@gadomski gadomski mentioned this pull request Jun 30, 2023
Merged
5 tasks
@jsignell jsignell mentioned this pull request Sep 13, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees

@jsignell jsignell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include some jsonschema documents in the pystac distribution
2 participants
@jsignell @gadomski