Pull FIELDS_JSON_URL into the codebase on release #1045
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1045 /- ##
==========================================
- Coverage 90.34% 90.24% -0.11%
==========================================
Files 47 47
Lines 6213 6220 7
Branches 929 931 2
==========================================
Hits 5613 5613
- Misses 422 427 5
- Partials 178 180 2 ☔ View full report in Codecov by Sentry. |
|
Phew 😅 that was a lot of fails in a row, but should be ready for review now. |
The reason for the mixed type enum is that there are mixed types in the original fields.json. So the enum is just smoothing over an oddity in the upstream definition. I don't really see how we can do anything about it in pystac itself as long as we still want to accept arbitrary fields json. |
There was a problem hiding this comment.
LGTM ... I also re-added FIELDS_JSON_URL as a deprecated field, w/ a plan to remove in v2.
Because we're adding a new module, this is technically a feature-adding, backwards compatible change, so needs to be in v1.8. I'm going to hold off on merging until #1049 lands and we release v1.7.1.
gadomski
force-pushed
the
load-file
branch
2 times, most recently
from
0c798a0 to
c43a974
Compare
Related Issue(s):
Description:
This PR adds a step to the release process that pulls the remote file and puts it in a particular location where it can be read from the pystac code and bundled up with the code when packaging.
I did not try to tackle the question of cleaning up the Enum because of the option to pass in custom fields. I don't see an easy way to clean this up without breaking backwards compat.
PR Checklist:
pre-commithooks pass locallyscripts/test)