network/discovery: rate limit skipped peers log #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zktaiga
requested changes
Oct 19, 2024
network/discovery/metrics.go
Outdated
| metricSkippedPeers = promauto.NewCounterVec(prometheus.CounterOpts{ | ||
| Name: "ssv:network:discovery:skipped_peers", | ||
| Help: "Counts skipped peers", | ||
| }, []string{"enr", "peer_id", "err"}) |
There was a problem hiding this comment.
Having peer ID or an ENR as a label is problematic because of its high cardinality (Prometheus struggles with this). We could use something such as ssv:network:discovery:skipped_peers_total for now if a total count would help. If not, we need some other solution.
There was a problem hiding this comment.
@zktaiga reverted the change and added the log rate limit
nkryuchkov
changed the title
y0sher
approved these changes
Oct 20, 2024
zktaiga
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zktaiga reported that this log makes up to 40% of stage logs