Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain names should be resolved on the remote host if --dns is specified #965

Open
fandreuz opened this issue May 25, 2024 · 0 comments
Open

Comments

@fandreuz
Copy link

I noticed that domain names passed as CLI arguments to sshuttle are resolved locally via socket.getaddrinfo. In some cases the name is only resolvable by the remote host (e.g. private VPCs), which I think is the use case for --dns. In such a situation, the script fails with Unable to resolve address ...

I propose to allow resolving the names on the remote machines if --dns appears in the command; either always, or only if the name cannot be resolved, if backward compatibility is a concern in this case.

Related to #844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant