Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

added credentials provider for basic auth #353

Closed
wants to merge 2 commits into from

Conversation

jdoklovic
Copy link

Fixes #350

@codecov
Copy link

codecov bot commented Apr 20, 2017

Codecov Report

Merging #353 into master will decrease coverage by 0.6%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #353       /-   ##
==========================================
- Coverage   77.34%   76.73%   -0.61%     
==========================================
  Files         122      122              
  Lines        8460     8462        2     
==========================================
- Hits         6543     6493      -50     
- Misses       1191     1259       68     
  Partials      726      710      -16
Impacted Files Coverage Δ
plumbing/transport/http/common.go 76% <77.77%> ( 5.62%) ⬆️
plumbing/transport/ssh/common.go 0% <0%> (-56.15%) ⬇️
plumbing/transport/ssh/auth_method.go 27.27% <0%> (-30.83%) ⬇️
plumbing/format/packfile/scanner.go 70.58% <0%> (ø) ⬆️
plumbing/object/change_adaptor.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48d3264...37beabc. Read the comment docs.

@bzz
Copy link
Contributor

bzz commented May 4, 2017

Number of CI failures on Win might be related to #369

Ping @smola @alcortesm @mcuadros for a review

@jdoklovic
Copy link
Author

I'm not sure how those failures got introduced unless windows tests were failing on master when i branched.
My changes are obviously very small and don't have anything to do with the failures listed

@jdoklovic
Copy link
Author

@smola @mcuadros any suggestions on how to fix this up and get it merged? I need this change for a CLI tool i'm building...

@smola
Copy link
Collaborator

smola commented May 9, 2017

@bzz Please, just ignore Windows failures, except for PR fixing stuff on Windows.

@smola
Copy link
Collaborator

smola commented May 9, 2017

Closing. See: #350 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants