Refresh live compose scan by observing RecomposerInfo instead of only the top-most recompose scope. #135
Conversation
… the top-most recompose scope.
zach-klippenstein
requested review from
jamesmosley55,
pyricau and
a team
as code owners
|
Is there a "I have no idea what YOU're doing" dog meme? |
| viewFilter = skipComposeTestTagsFilter(LIVE_HIERARCHY_TEST_TAG) | ||
| ) | ||
| LaunchedEffect(Unit) { | ||
| runLiveScanning { liveHierarchy.value = it } |
There was a problem hiding this comment.
cool so this effectively says "rescan every time we've recomposed". btw does that not retrigger a composition / any risk of infinite loop?
There was a problem hiding this comment.
Correct. It does not trigger infinite composition loop, although I'm not super clear on why not. I can look into it and document, because it does seem like that should happen.
- Figure out why no infinite loop
There was a problem hiding this comment.
Ok I get why there's no infinite loop now. Because we exclude the scan result composable from the scan, a scan in which only the scan output changes will result in the scan string being set to the same value, which won't invalidate any recompose scopes.
I'll add a comment about this and punch up the docs on the Recomposers stuff.
|
This makes use of the new Flow-based APIs for observing Recomposer state.