KSP2 throws `NoSuchElementException` for data classes with `@JsonAdapter(generateAdapter = true)` #1870

Hiraev · 2024-07-27T22:24:42Z

Issue

When the ksp.useKSP2 flag is enabled, KSP2 throws a java.util.NoSuchElementException under two specific
cases:

when data classes are annotated with @JsonAdapter(generateAdapter = true)
when enum classes are annotated with @JsonAdapter(generateAdapter = false) (notwithstanding their lack of necessity)

Environment

Kotlin 2.0.0
KSP 2.0.0-1.0.23
Moshi 1.15.1
Java 17
Gradle 8.5
macOS Sonoma 14.1

Example

To recreate the issue, follow these instructions:

Prepare directories for project

mkdir -p k2 k2/gradle k2/src/main/kotlin/org/example; cd k2

Create libs.versions.toml

echo '
[versions]
kotlin = "2.0.0"
ksp = "2.0.0-1.0.23"
moshi = "1.15.1"

[libraries]
moshi = { module = "com.squareup.moshi:moshi", version.ref = "moshi" }
moshi-codegen = { module = "com.squareup.moshi:moshi-kotlin-codegen", version.ref = "moshi" }

[plugins]
jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
ksp = { id = "com.google.devtools.ksp", version.ref = "ksp" }
' > gradle/libs.versions.toml

Create build.gradle.kts

echo '
plugins {
    alias(libs.plugins.jvm)
    alias(libs.plugins.ksp)
}

repositories {
    mavenCentral()
}

dependencies {
    ksp(libs.moshi.codegen)
    implementation(libs.moshi)
}

java {
    toolchain {
        languageVersion = JavaLanguageVersion.of(17)
    }
}
' > build.gradle.kts

Create Kotlin file

echo '
package org.example

import com.squareup.moshi.JsonClass

@JsonClass(generateAdapter = true)
data class Person(val a: Int)

@JsonClass(generateAdapter = false)
enum class Cell {
    BLACK,
    WHITE,
}
' > src/main/kotlin/org/example/Example.kt

Add Gradle wrapper

gradle wrapper --gradle-version 8.5 --distribution-type all

Build project without KSP2

./gradlew build -Pksp.useKSP2=false

This build finishes successfully.

Build project with ksp2

./gradlew build -Pksp.useKSP2=true

This build fails with exception

> Task :kspKotlin FAILED
e: [ksp] java.util.NoSuchElementException: Collection contains no element matching the predicate.

Removing the data modifier from the Person class and the annotation from the enum class allows the KSP processor to complete its task without encountering any issues.

Interesting point. Next test in JsonClassSymbolProcessorTest passes successfully.

  @Test
  fun generateAdapterForDataClass() {
    val result = compile(
      kotlin(
        "source.kt",
        """
          package test
          import com.squareup.moshi.JsonClass

          @JsonClass(generateAdapter = true)
          data class Person(val a: Int)
          """,
      ),
    )

    assertThat(result.exitCode).isEqualTo(KotlinCompilation.ExitCode.OK)
  }

The text was updated successfully, but these errors were encountered:

ZacSweers · 2024-07-27T23:24:03Z

Upstream bug google/ksp#1998

Hiraev added the bug label Jul 27, 2024

Hiraev changed the title ~~KSP2 throws java.util.NoSuchElementException for data classes with @JsonAdapter(generateAdapter = true)~~ KSP2 throws NoSuchElementException for data classes with @JsonAdapter(generateAdapter = true) Jul 27, 2024

ZacSweers closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KSP2 throws `NoSuchElementException` for data classes with `@JsonAdapter(generateAdapter = true)` #1870

KSP2 throws `NoSuchElementException` for data classes with `@JsonAdapter(generateAdapter = true)` #1870

Hiraev commented Jul 27, 2024

ZacSweers commented Jul 27, 2024

KSP2 throws NoSuchElementException for data classes with @JsonAdapter(generateAdapter = true) #1870

KSP2 throws NoSuchElementException for data classes with @JsonAdapter(generateAdapter = true) #1870

Comments

Hiraev commented Jul 27, 2024

Issue

Environment

Example

ZacSweers commented Jul 27, 2024

KSP2 throws `NoSuchElementException` for data classes with `@JsonAdapter(generateAdapter = true)` #1870

KSP2 throws `NoSuchElementException` for data classes with `@JsonAdapter(generateAdapter = true)` #1870