Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLite: Add GLOB, MATCH. Improved REGEXP #5745

Merged
merged 1 commit into from
Apr 4, 2024
Merged

SQLite: Add GLOB, MATCH. Improved REGEXP #5745

merged 1 commit into from
Apr 4, 2024

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Apr 3, 2024

Brief summary of the change made

This adds GLOB, MATCH, and improves REGEXP in SQLite.

  • Fixed handling of NOT REGEXP
  • Added PatternMatchingGrammar in ANSI for future support in other dialects such as DuckDB.

fixes #5717

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17399      0   100%

225 files skipped due to complete coverage.

@coveralls
Copy link

Coverage Status

coverage: 99.984%. remained the same
when pulling 3f4e4cd on keraion:sqlite_glob
into 127e07e on sqlfluff:main.

WittierDinosaur
WittierDinosaur approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Apr 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2024
@WittierDinosaur WittierDinosaur added this pull request to the merge queue Apr 4, 2024
Merged via the queue into sqlfluff:main with commit ca60440 Apr 4, 2024
28 checks passed
@keraion keraion deleted the sqlite_glob branch April 4, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GLOB function is unparsable
3 participants
@keraion @coveralls @WittierDinosaur