Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NoSQL databases #915

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Remove NoSQL databases #915

merged 1 commit into from
Mar 9, 2024

Conversation

malwaregarry
Copy link
Collaborator

Removed NoSQL databases so that it is easier to consolidate code for the refactoring effort.

Databases removed:

  • MongoDB
  • ArangoDB
  • Cosmos

mrigger
mrigger approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@mrigger mrigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just for documentation: these implementations are, to the best of my knowledge, not actively used and make it more difficult to maintain SQLancer and hinder the ongoing efforts to improve SQLancer's architecture.

@mrigger mrigger merged commit ece708d into sqlancer:main Mar 9, 2024
11 of 21 checks passed
albertZhangTJ pushed a commit to albertZhangTJ/sqlancer-lancerfuzz that referenced this pull request Mar 20, 2024
@malwaregarry @albertZhangTJ
Remove NoSQL database (sqlancer#915)
e5f4415
@NayameoW
Copy link

Hi, thanks for your commit. I merged it into my working branch but encountered an issue. Here’s the exception that was thrown:
Exception in thread "main" java.util.ServiceConfigurationError: sqlancer.DatabaseProvider: Provider sqlancer.arangodb.ArangoDBProvider not found
Could you please help me with this? Thank you!

@mrigger
Copy link
Contributor

mrigger commented Apr 20, 2024

Did you try mvn clean? If that doesn't work, something might have gone wrong with your merge.

@NayameoW
Copy link

Did you try mvn clean? If that doesn't work, something might have gone wrong with your merge.

Thanks! Something went wrong with my IDEA, and this really helps.

@mrigger mrigger mentioned this pull request Aug 23, 2024
Merged
@malwaregarry malwaregarry mentioned this pull request Sep 2, 2024
Closed
@malwaregarry malwaregarry deleted the remove-nosql branch September 18, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrigger mrigger mrigger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malwaregarry @NayameoW @mrigger