Skip to content
This repository has been archived by the owner on Aug 24, 2022. It is now read-only.

Translating assemblies called "*System" #183

Closed
TeeTrizZz opened this issue Apr 19, 2013 · 9 comments
Closed

Translating assemblies called "*System" #183

TeeTrizZz opened this issue Apr 19, 2013 · 9 comments

Comments

@TeeTrizZz
Copy link

Hi Kevin,

We called a project and its assembly "SolarSystem" and it looks like JSIL is like "Oh, it's called *System, so let's not translate it." - The resulting output is the usual SolarSystem.js file where, however, a lot of functions are missing (e.g. main). After renaming the assembly to Solar it works. (Keep in mind that we use JSIL with the *.exe instead of the solution.)

Can you look into this, please?

Thanks,
Fabian

@kg
Copy link
Member

kg commented Apr 19, 2013

Hi, I think I know what the problem is here.

Can you try changing this line in defaults.jsilconfig:

      "System.*",

To:

  "^System\\.*",

I think the stub regex is probably matching against 'SolarSystem' when it should only match assembly names starting with 'System.'.

@TeeTrizZz
Copy link
Author

Yup, that's the prob.

@kg
Copy link
Member

kg commented Apr 19, 2013

OK, for now I suggest patching the defaults.jsilconfig yourself to address that. In the future I will update all the defaults to avoid this problem.

@kg
Copy link
Member

kg commented Apr 24, 2013

97f3215 should address this and provide better feedback from JSILc.exe as to whether an assembly has been stubbed or translated (ignored doesn't currently write a message out, but that is trivial to add if it becomes a problem as well).

I'll probably merge it to master in a few days, but you can cherry-pick it until then.

@kg
Copy link
Member

kg commented Apr 24, 2013

Should be fixed on master now. Let me know if it's not.

@kg kg closed this as completed Apr 24, 2013
@TeeTrizZz
Copy link
Author

It's still broken.

Loaded ......\Bin\Debug\Examples\SolarSystem\Examples.SolarSystem.exe (stubbed)

This works:

"^System\\.*",

This doesn't:

  "System,",
  "System\\.(.*),",

@kg
Copy link
Member

kg commented May 3, 2013

I had to remove the ^ because it was causing other problems. I'll look into this more, I guess...

@kg kg reopened this May 3, 2013
kg added a commit that referenced this issue May 14, 2013
…d the values in defaults.jsilconfig

Attempt to fix issue #183 for real this time, and add a test.
@kg
Copy link
Member

kg commented May 14, 2013

OK, I think this one should do the trick.

@TeeTrizZz
Copy link
Author

Good commit! Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants