-
Notifications
You must be signed in to change notification settings - Fork 241
Translating assemblies called "*System" #183
Comments
Hi, I think I know what the problem is here. Can you try changing this line in defaults.jsilconfig:
To:
I think the stub regex is probably matching against 'SolarSystem' when it should only match assembly names starting with 'System.'. |
Yup, that's the prob. |
OK, for now I suggest patching the defaults.jsilconfig yourself to address that. In the future I will update all the defaults to avoid this problem. |
97f3215 should address this and provide better feedback from JSILc.exe as to whether an assembly has been stubbed or translated (ignored doesn't currently write a message out, but that is trivial to add if it becomes a problem as well). I'll probably merge it to master in a few days, but you can cherry-pick it until then. |
Should be fixed on master now. Let me know if it's not. |
It's still broken.
This works:
This doesn't:
|
I had to remove the ^ because it was causing other problems. I'll look into this more, I guess... |
…d the values in defaults.jsilconfig Attempt to fix issue #183 for real this time, and add a test.
OK, I think this one should do the trick. |
Good commit! Thanks! |
Hi Kevin,
We called a project and its assembly "SolarSystem" and it looks like JSIL is like "Oh, it's called *System, so let's not translate it." - The resulting output is the usual SolarSystem.js file where, however, a lot of functions are missing (e.g. main). After renaming the assembly to Solar it works. (Keep in mind that we use JSIL with the *.exe instead of the solution.)
Can you look into this, please?
Thanks,
Fabian
The text was updated successfully, but these errors were encountered: