Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic project documentation and example usage #85

Open
14 tasks
goanpeca opened this issue Oct 27, 2016 · 13 comments
Open
14 tasks

Add basic project documentation and example usage #85

goanpeca opened this issue Oct 27, 2016 · 13 comments
Assignees
Milestone

Comments

@goanpeca
Copy link
Member

goanpeca commented Oct 27, 2016

Written and edited by @CAM-Gerlach (OP was initially empty):

@goanpeca goanpeca added this to the v1.2 milestone Oct 27, 2016
@goanpeca goanpeca self-assigned this Oct 27, 2016
@SylvainCorlay
Copy link
Member

SylvainCorlay commented Oct 27, 2016

FYI, readthedocs is not very good to deal with dependencies like Qt. But it now supports a conda environment.yml. Check out qtawesome's rtd configuration (readthedocs.yml environment.yml).

@ccordoba12 ccordoba12 modified the milestones: v1.2, v1.3 Jan 2, 2017
@ccordoba12 ccordoba12 modified the milestones: v1.3, v1.4 May 8, 2017
@AndydeCleyre
Copy link

Do the docs exist in some format?

@ccordoba12 ccordoba12 modified the milestones: v1.4, v1.5 Mar 11, 2018
@ccordoba12 ccordoba12 modified the milestones: v1.5, v2.0 Jun 11, 2018
@machinekoder
Copy link

A simple example in the README would work as well.

@goanpeca goanpeca added the v2.0 label Feb 19, 2020
@goanpeca goanpeca removed this from the v2.0 milestone Feb 19, 2020
@goanpeca goanpeca removed their assignment Aug 22, 2020
@ccordoba12 ccordoba12 added this to the v2.0.0 milestone Aug 10, 2021
@ccordoba12 ccordoba12 removed the v2.0 label Aug 10, 2021
@dalthviz dalthviz changed the title Make docs (readthedocs?) Add basic project documentation Nov 4, 2021
@dalthviz dalthviz changed the title Add basic project documentation Add basic project documentation or example usage Nov 4, 2021
@dalthviz dalthviz changed the title Add basic project documentation or example usage Add basic project documentation and example usage Nov 4, 2021
@dalthviz
Copy link
Member

dalthviz commented Nov 4, 2021

@CAM-Gerlach would you like to work on this?

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Nov 4, 2021

I can't promise anything like a full-on docs site like we have for spyder-docs or the API docs (at least in the near term), but I was actually already planning to at least update and expand the README and add a contributing/dev guide to address some of these issues (and replied in each of them with more detail).

It looks like the simplest low-hanging fruit item being requested here (beyond the more specific needs identified in the linked issues, which I responded to), was a few examples of using QtPy instead of the specific bindings; I can try to make some up based on what Spyder does, but as I'm nowhere near a Qt expert, @dalthviz if you could point to or outline some common examples that would be really helpful.

Also, as I know there have been questions and requests to clarity the existing API that QtPy generally follows, I'd think we might want to revise this sentence:

Basically, you can write your code as if you were using PySide2 but import Qt modules from qtpy instead of PySide2 (or PyQt5)

to say "as if you were using PyQt5", since as I understand that's the API that QtPy generally follows at present, and also list the Qt6 APIs there, as well as link the Qt and PyQt5 docs. That would then be a jumping-off point for the additions in #61 that explain where QtPy diverges from that documented baseline.

If there's any other low-hanging fruit you would like me to try to do as part of this issue, as opposed to one of the more specific ones or a follow, please do let me know!

@CAM-Gerlach CAM-Gerlach self-assigned this Nov 5, 2021
@CAM-Gerlach
Copy link
Member

As another low-hanging fruit item, the __init__.py contains a substantial amount of general information and examples in its docstring that could be moved to or included in the README to be much more visible, with a bit of cleanup.

@dalthviz
Copy link
Member

dalthviz commented Nov 5, 2021

I think adding some more information in the README is good enough and using the info already in the __init__ could be nice 👍 Thanks @CAM-Gerlach!

Also, at #200 (comment) a mention to a documentation page that the Glue project has related to QtPy (in terms of how to use it) could be useful too

@CAM-Gerlach
Copy link
Member

Great, that's helpful thanks. I'll compile a master list of the things we want to add in the OP and links thereof, since it doesn't have any content as it is.

@CAM-Gerlach
Copy link
Member

Not directly related, but I think it would be a good idea to add back the old PYQT4 and PYSIDE package-level constant, always set to False, for backward compat for code that checks them, and document them here? We did retain the now-obsolete is_old_pyqt and is_pyqt46 variables which were only used internally and not indicated as public module-level constants (ALL_CAPS), so it would make much more sense to include those as well/instead (since external code might be checking for them). I can submit a PR if you agree.

@CAM-Gerlach
Copy link
Member

Updated the OP as discussed above

@dalthviz
Copy link
Member

dalthviz commented Nov 8, 2021

Not directly related, but I think it would be a good idea to add back the old PYQT4 and PYSIDE package-level constant, always set to False, for backward compat for code that checks them, and document them here?

Makes sense to me 👍

@CAM-Gerlach
Copy link
Member

Thanks, opened as PR #279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants