Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAJDBC-551 - Supports derived delete. #230

Closed
wants to merge 1 commit into from

Conversation

lseeker
Copy link
Contributor

@lseeker lseeker commented Jun 18, 2020

Implements DATAJDBC-551, delete relations by subquery.

JdbcDeleteQueryCreator creates stream chain of delete queries, and executed by modifying query executor.

Copy link
Contributor

@schauder schauder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good and thanks for rebasing it on the current master.

In order to merge this we need a proper set of unit tests ensuring the right kind of SQL in generated.
The following cases should be covered:

  • deleting an aggregate with at least two level reference, i.e. root->child->grandchild
  • similar as above, but with one level replaced by an embedded entity.
  • deleting an aggregate by a direct attribute
  • deleting an aggregate by an indirect attribute

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2021
@schauder schauder removed the status: waiting-for-triage An issue we've not yet triaged label Jan 15, 2021
@schauder schauder self-assigned this Jan 15, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 15, 2021
@schauder schauder removed the status: waiting-for-triage An issue we've not yet triaged label Jan 18, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 18, 2021
@schauder schauder linked an issue Feb 26, 2021 that may be closed by this pull request
@schauder schauder removed the status: waiting-for-triage An issue we've not yet triaged label Feb 26, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 26, 2021
@Mintas
Copy link

Mintas commented Apr 9, 2021

Hello! Any progress on this issue?

@gregturn gregturn changed the base branch from master to main April 15, 2021 18:21
@schauder schauder added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 7, 2021
mp911de added a commit that referenced this pull request Feb 21, 2022
We support Oracle's experimental R2DBC driver by providing a dialect including bind markers. Since the driver is not yet available from Maven Central and it requires module-path support for ServiceLoader discovery, we need to apply a few workarounds including absence check for our integration tests.

See #230
mp911de added a commit that referenced this pull request Feb 21, 2022
Make count assertions case-insensitive regarding the count column name. Add missing license headers. Support DatabaseContainer without a database name.

See #230
@kota65535
Copy link

I'm surprised that this feature has not yet been implemented, even though the documentation says it is supported with examples.
https://docs.spring.io/spring-data/jdbc/docs/current/reference/html/#repositories.core-concepts

Is there any progress?

@schauder
Copy link
Contributor

Superseeded by #1486

@schauder schauder closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add query derivation for delete queries [DATAJDBC-551]
5 participants