Issue/1828 aggregate ref with convertable #1829
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifying test code
This was referenced Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue at hand, but in an ad hoc way, which feels very wrong. I still feel like I/we are doing something wrong with these conversions.
The problem here is:
Given an
AggregateReference<E, C>withEan entity andCa type for which a write converter is regsitered, we currently determineCas the target type of the conversion.With this information we call the
AggregateReferenceconverter, which extracts the id value and determines it is done, because the result is of the desired target type.This is demonstrated by the failing new unit test.
The integration test is fixed by just slapping a
getPotentiallyConvertedSimpleWriteon the already converted type, which looks exactly for the customconversions, that we currently missing.But this means we do 2 custom conversions. Why 2? Why not arbitrary many?