Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change owasp 2013 to owasp 2017 #238

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

change owasp 2013 to owasp 2017 #238

wants to merge 3 commits into from

Conversation

LeGrandMaxime
Copy link

Hi,
I want to change owasp 2013 to owasp 2017.
I put version 3.11-SNAPSHOT in the pom xml, I didn't know what to put.

h3xstream
h3xstream approved these changes Jan 2, 2019
View reviewed changes
generate_profiles/BuildXmlFiles.groovy
@@ -123,42 123,22 @@ def writeRules(String rulesSetName,List<Plugin> plugins,List<String> includedBug
description(pattern.Details.text().trim())

//OWASP TOP 10 2017
if (pattern.Details.text().toLowerCase().contains('injection') || pattern.Details.text().contains('A1-Injection')) {
if (pattern.Details.text().toLowerCase().contains('injection') || pattern.Details.text().contains('2017_A1-Injection')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: The second condition is redundant. The first will always match first.

I would not require a change. The code might be clearer this way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized it was already like that.. nvm.

@h3xstream
Copy link
Member

h3xstream commented Aug 26, 2019 •
edited
Loading

The smoke test is not running @VinodAnandan

Digest: sha256:bf99084b436f41616aac766593d7fbe6852a689965cfee801e8fe9cae24445a9
Status: Downloaded newer image for sonarqube:7.9-community
 ---> a84a2ad61bb7
Step 2/4 : ENV SONAR_JAVA_VERSION=5.13.1.18282
 ---> Running in 4dc5d2757b18
Removing intermediate container 4dc5d2757b18
 ---> eef89d1060d9
Step 3/4 : RUN wget -P $SONARQUBE_HOME/extensions/plugins/ --no-verbose https://repo.maven.apache.org/maven2/org/sonarsource/java/sonar-java-plugin/$SONAR_JAVA_VERSION/sonar-java-plugin-$SONAR_JAVA_VERSION.jar
 ---> Running in 1211f4c83a9f
/bin/sh: 1: wget: not found
ERROR: Service 'sonarqube-latest' failed to build: The command '/bin/sh -c wget -P $SONARQUBE_HOME/extensions/plugins/ --no-verbose https://repo.maven.apache.org/maven2/org/sonarsource/java/sonar-java-plugin/$SONAR_JAVA_VERSION/sonar-java-plugin-$SONAR_JAVA_VERSION.jar' returned a non-zero code: 127

@gtoison gtoison mentioned this pull request Nov 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aepfli aepfli aepfli left review comments

@h3xstream h3xstream h3xstream approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeGrandMaxime @h3xstream @aepfli