Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoice status is PR_UNCONFIRMED even if wallet history only has a local tx #8939

Open
agatee8787 opened this issue Mar 12, 2024 · 4 comments
Labels
enhancement ✨ topic-invoice-payreq invoices and payment requests topic-wallet 👛 related to wallet.py, or maybe address_synchronizer.py/coinchooser.py

Comments

@agatee8787
Copy link

Hello, I sent a small part of the mBTC to see if they would come to Binance, that is: I copied the address of the wallet on the Binance exchange. I entered how much mBTC I want to send from Electrum to the exchange. I clicked send and entered the password to confirm this transaction. The fee was charged
After about 15 hours, the transaction became visible in the Electrum transaction list, but the transaction title is highlighted in red. There is also the info "Local" next to it.
In the "Send" tab next to the transaction there is the info "unconfirmed". Someone on bitcointalk.org gave me an advice to report that thing here so I am doing that. Reason: "That is unintended"
This happened while transferring bitcoin from the desktop wallet to the exchange. I did the transaction, but it turned out to be only partially, because it needs a few signatures, and I have "signed 1/2" marked.

@ecdsa
Copy link
Member

ecdsa commented Mar 12, 2024

it looks like you are using a multisig wallet. Since you do not seem to be aware of that, I suppose it is a wallet with two-factor authentication. Maybe you saved the local transaction without broadcasting it?

@agatee8787
Copy link
Author

Hello, yes, about having multisig wallet I already know from other forum, before wasn't aware about that. Here just wanted to write about a bug/error. Like I wrote:
"In the "Send" tab next to the transaction there is the info "unconfirmed". Someone on bitcointalk.org gave me an advice to report that thing here so I am doing that."
And the advice the person gave me, sharing that reason: "That is unintended"

@SomberNight
Copy link
Member

@ecdsa I guess OP's point is that the invoice/request gets into the PR_UNCONFIRMED state from either a mempool tx or a local tx, and if it happens for a local tx, then that is potentially confusing for the user. We could potentially split PR_UNCONFIRMED into two states to be able to distinguish these.

@SomberNight SomberNight changed the title Transaction signed "unconfirmed" invoice status is PR_UNCONFIRMED even if wallet history only has a local tx Mar 12, 2024
@SomberNight SomberNight added topic-invoice-payreq invoices and payment requests topic-wallet 👛 related to wallet.py, or maybe address_synchronizer.py/coinchooser.py enhancement ✨ labels Mar 12, 2024
@SomberNight
Copy link
Member

From IRC:

<s7r> [...] this also breaks electrum in merchant mode?
<s7r> e.g. I send to an electrum merchant a tx, and cancel it (RBF double spend) from my electrum client. In the merchant it will remain as Unconfirmed (Local) forever.
<s7r> we need to split PR_UNCONFIRMED in complete | partially_signed | local
<s7r> and a way to automatically remove / expire payment requests that have a LOCAL transaction for more than N seconds, something like this
<s7r> oh, or mempool TX or local TX maybe, since mempool will not accept a TX if not completely signed. as well as if its parent UTXO is spent in a RBF double-spend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ topic-invoice-payreq invoices and payment requests topic-wallet 👛 related to wallet.py, or maybe address_synchronizer.py/coinchooser.py
Projects
None yet
Development

No branches or pull requests

3 participants