Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1816] Fix explorer rendering #2589

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Conversation

ameer2468
Copy link
Contributor

This PR: Fixes initial rendering of explorer by making sure the initial rendering is successful and not blank.

  • Also fixes updating gap values when "show tags" is toggled, previously it would take a few toggles for Explorer to update, now it's instant.

@ameer2468 ameer2468 requested a review from a team as a code owner July 5, 2024 23:34
Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2024 0:12am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
spacedrive-landing ⬜️ Ignored (Inspect) Visit Preview Jul 6, 2024 0:12am

Copy link

linear bot commented Jul 5, 2024

update dep

Make sure it runs only once

make sure to include loading value in other explorer routes

rewrite condition to prevent loop
@ameer2468 ameer2468 added this pull request to the merge queue Jul 6, 2024
Merged via the queue into main with commit 0da620b Jul 6, 2024
11 checks passed
@ameer2468 ameer2468 deleted the eng-1815-fix-explorer-rendering branch July 6, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants