Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simper_eq bugs #81

Open
Tremus opened this issue May 6, 2022 · 0 comments
Open

simper_eq bugs #81

Tremus opened this issue May 6, 2022 · 0 comments

Comments

@Tremus
Copy link

Tremus commented May 6, 2022

Bug 1: The high shelf cutoff moves when boosting / cutting

SOUL/source/soul_library/soul_library_filters.soul

Line 1532 in 2f8f74e

let g = w / sqrt (A);

Solution:
let g = w * sqrt (A);

Bug 2: The bell filters quality is not symmetrical when boosting / cutting

SOUL/source/soul_library/soul_library_filters.soul

Lines 1574 to 1578 in 2f8f74e

c.a1 = 1 / (1 g * (g k));
c.a2 = g * c.a1;
c.a3 = g * c.a2;
c.m0 = 1;
c.m1 = k * (A * A - 1);

Solution:
k = 1 / (A * clamp(quality, 0.01, 100.0));

NOTE: The bell filter is the only filter that uses a different k

Source: https://cytomic.com/files/dsp/SvfLinearTrapOptimised2.pdf
Page 32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tremus