Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image scanning pending count #64

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
Open

Conversation

jaidan22
Copy link

fix for #58

While scanning from various multi page scanners(HP) only first page is returned because DG_CONTROL / DAT_PENDINGXFERS / MSG_GET is returning 1. Removed this check for image scanning, as it is not required to check pending count while entering loop.

@jaidan22 jaidan22 changed the title #58 fix image scanning pending count fix image scanning pending count Sep 25, 2024
@jaidan22 jaidan22 marked this pull request as draft September 25, 2024 13:32
@jaidan22 jaidan22 marked this pull request as ready for review September 26, 2024 06:24
@soukoku
Copy link
Owner

soukoku commented Sep 26, 2024

Not sure I understand why yet. HP driver doesn't support this operationg correctly? Is it giving incorrect values or even non-success when calling it? The result of the initial pending count is used in the TransferReadyEventArgs so it's not an unnecessary call.

@jaidan22
Copy link
Author

jaidan22 commented Sep 26, 2024

It is giving incorrect value, even after setting capabilities correctly. Initial value is set to 1 and on next EndXfer value is decremented to 0, even though the count is passed in TransferReadyEventArgs, since the initial value is set to 'DoNotCare' - will it be an issue? Also on testing on TWACKER, it doesn't seem to send the pending count initially.

@soukoku
Copy link
Owner

soukoku commented Sep 26, 2024

If problem is happening after EndXfer then the PR shouldn't fix it (unless it does?). It may be a bug where TWPendingXfers count needs to be reset to DoNotCare before making calls with it.

@jaidan22
Copy link
Author

Doesn't seem to be the problem with EndXfer, it returns the correct pending count in each iteration. But only when pending count is initially 1, it just decrements the value. With pending set DoNotCare at first, it's working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants