Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ecosystem CI]: Integration in the vite-ecosystem-ci #1417

Open
2 tasks done
birkskyum opened this issue Mar 25, 2024 · 2 comments
Open
2 tasks done

[Ecosystem CI]: Integration in the vite-ecosystem-ci #1417

birkskyum opened this issue Mar 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@birkskyum
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

For stability, it would be good to be in the vite-ecosystem-ci

I'm self-assigning this task.

Examples 🌈

No response

Motivation 🔦

No response

@birkskyum birkskyum added the enhancement New feature or request label Mar 25, 2024
@birkskyum
Copy link
Contributor Author

birkskyum commented Apr 9, 2024

For both vite-plugin-solid and solid-start, we need a test entry in the package.json scripts that the vite-ecosystem-ci should run after cloning the repo. There aren't test suites for either repos currently, so that has to be added before this can proceed.

@birkskyum birkskyum changed the title [Feature?]: Integration in the vite-ecosystem-ci [Ecosystem CI]: Integration in the vite-ecosystem-ci Apr 9, 2024
@birkskyum
Copy link
Contributor Author

As a start the solid-testing-library would be good to include in the ecosystem-ci, because it tests the vite-plugin-solid. It's test suite is unfortunately broken. Theres a PR with Github workflow here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant