Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature to use rustls instead of default for dependancy rusoto #55

Merged
merged 2 commits into from
May 3, 2019

Conversation

jeprojects
Copy link
Contributor

What did you implement:

Closes: #50

How did you verify your change:

Ran tests using rustls and default features

What (if anything) would need to be called out in the CHANGELOG for the next release:

Added feature to use rustls instead of default for dependancy rusoto

Usage:
Cargo.toml
rusoto_core = { version = "0.38.0", default_features = false, features = ["rustls"] }
dynomite = { version = "0.4.0", default_features = false, features = ["rustls"] }

Copy link
Owner

@softprops softprops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sane. I'll take a closer look when I get home tonight. I can cut a release tonight as well if this checks out

@softprops softprops merged commit a5fffd3 into softprops:master May 3, 2019
@softprops
Copy link
Owner

@jeprojects published a new 0.4.1 release containing this change https://github.com/softprops/dynomite/blob/master/CHANGELOG.md#041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build when using rustls instead of OpenSSL in rusoto_core
2 participants