Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary GcPointer field #37

Merged
merged 2 commits into from
May 10, 2021
Merged

Remove unnecessary GcPointer field #37

merged 2 commits into from
May 10, 2021

Conversation

jacob-hughes
Copy link
Collaborator

This was originally used to stop the NonNull affecting the Send Sync impl on the Gc. However, it's much easier to just use conditional trait impls, e.g.:

    unsafe impl<T: Send> Send for Gc<T> {}

@jacob-hughes
Move GC tests into common directory
188807b
@jacob-hughes
Remove unnecessary GcPointer field
a20da05 
This was originally used to stop the `NonNull` affecting the `Send  
Sync` impl on the `Gc`. However, it's much easier to just conditional
trait impls, e.g.:

    unsafe impl<T: Send> Send for Gc<T> {}
@ltratt
Copy link
Member

ltratt commented May 10, 2021

bors r

@bors
Copy link

bors bot commented May 10, 2021

Build succeeded:

@bors bors bot merged commit 52cf679 into softdevteam:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ltratt ltratt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacob-hughes @ltratt