Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.3.3
Choose a base ref
...
head repository: socketio/socket.io-parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.3.4
Choose a head ref
  • 2 commits
  • 5 files changed
  • 2 contributors

Commits on Jul 22, 2024

  1. fix: check the format of the event name (#125) 

    A packet like '2[{"toString":"foo"}]' was decoded as:

{
  type: EVENT,
  data: [ { "toString": "foo" } ]
}

Which would then throw an error when passed to the EventEmitter class:

> TypeError: Cannot convert object to primitive value
>    at Socket.emit (node:events:507:25)
>    at .../node_modules/socket.io/lib/socket.js:531:14

Backported from 3b78117
    @arnaufugarolas
    arnaufugarolas authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    ee00660 View commit details
    Browse the repository at this point in the history

  2. chore(release): 3.3.4 

    Diff: 3.3.3...3.3.4
    @darrachequesne
    darrachequesne committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    1e9ebc6 View commit details
    Browse the repository at this point in the history
Loading