This repository has been archived by the owner on May 29, 2018. It is now read-only.
Fix #355: Text not readable on error in entry (fg==bg) #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fg/bg colors should be different in entries (i.e. search entry in gedit). To make the text readable, the fg color is dynamically set using this approach: http://thesassway.com/intermediate/dynamically-change-text-color-based-on-its-background-with-sass Consider using the approach given at https://gist.github.com/jlong/f06f5843104ee10006fe which promises even better fg color determination. Resolves: snwh#355, snwh#383
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fg/bg colors should be different in entries (i.e. search entry in gedit).
To make the text readable, the fg color is dynamically set using this approach:
http://thesassway.com/intermediate/dynamically-change-text-color-based-on-its-background-with-sass
Consider using the approach given at https://gist.github.com/jlong/f06f5843104ee10006fe
which promises even better fg color determination.
Resolves: #355, #383