Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seastar::metrics::double_registration #365

Open
laomd opened this issue Nov 19, 2019 · 2 comments
Open

seastar::metrics::double_registration #365

laomd opened this issue Nov 19, 2019 · 2 comments

Comments

@laomd
Copy link

laomd commented Nov 19, 2019

Describe the bug
"seastar::metrics::double_registration: registering metrics twice for metrics: smf::rpc_server_active_connections" when run several rpc servers at the same time.

To Reproduce
for (int i = 0; i < 10; i ) {
smf::rpc_server_args opts;
opts.rpc_port = ports[i];
auto server = seastar::make_shared<smf::rpc_server>(opts);
...
}

To Fix
make metric name unique for each server, for example, "smf::rpc_server(" args.ip ":" seastar::to_sstring(args.rpc_port) ")" instead of "smf::rpc_server" only.

@emaxerrno
Copy link
Collaborator

@laomd great idea!

@emaxerrno
Copy link
Collaborator

i think we could have an optional server tag that the user can override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants