Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote priority of handling prometheus stats #353

Open
emaxerrno opened this issue Apr 24, 2019 · 1 comment
Open

Demote priority of handling prometheus stats #353

emaxerrno opened this issue Apr 24, 2019 · 1 comment

Comments

@emaxerrno
Copy link
Collaborator

Prometheus can add latency to the data path.

Use a low priority scheduling group for the metrics.

ref: https://groups.google.com/forum/#!topic/seastar-dev/adKyzRgqc5E

> with_scheduling_group(maintenance_scheduling_group, [&] { 
>                   return 
> prometheus_server.listen(ipv4_addr{prom_addr.addr_list.front(), 
> pport}).handle_exception([pport, &cfg] (auto ep) { 
>                     startlog.error("Could not start Prometheus API 
> server on {}:{}: {}", cfg->prometheus_address(), pport, ep); 
>                     return make_exception_future<>(ep); 
>                   }); 
>                 }).get(); 
@emaxerrno
Copy link
Collaborator Author

@noahdesu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant