Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistent option management #192

Open
emaxerrno opened this issue Feb 3, 2018 · 0 comments
Open

consistent option management #192

emaxerrno opened this issue Feb 3, 2018 · 0 comments
Assignees
@emaxerrno
Labels
enhancement good first issue help wanted

Comments

@emaxerrno
Copy link
Collaborator

we have 2 types of patterns


struct foo_opts {}
struct foo {
    foo (foo_opts) {}
}

and

struct foo {
    struct opts {}
    foo(foo::opts) {}
}

for lots of filesystem components.

consistently move them inside or outside.

Same for

struct foo {
    struct opts {}
    struct metrics {}

    private:
    metrics stats_;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emaxerrno emaxerrno

Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emaxerrno