Skip to content
This repository has been archived by the owner on Mar 10, 2024. It is now read-only.

feat: support unimported assets #148

Merged
merged 3 commits into from
May 10, 2023

Conversation

yyamanoi1222
Copy link
Contributor

@yyamanoi1222 yyamanoi1222 commented May 9, 2023

closes #91
closes #57

Add assetsExtensions on config for tracing assets files like jpeg, png, etc.
Files with extensions in assetsExtensions are not ignored when detecting unimported files and marked as resolved if imported.

Copy link
Owner

@smeijer smeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great. I only suggest we rename assetsExtensions to assetExtensions, as we also use entryFiles and not entriesFiles.

src/__tests__/cli.ts Outdated Show resolved Hide resolved
src/__tests__/cli.ts Outdated Show resolved Hide resolved
src/__tests__/cli.ts Outdated Show resolved Hide resolved
src/__tests__/print.ts Outdated Show resolved Hide resolved
src/__tests__/process.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/traverse.ts Outdated Show resolved Hide resolved
src/traverse.ts Outdated Show resolved Hide resolved
@smeijer smeijer force-pushed the feature/support_assets_extension branch from 35235bc to 08c1c28 Compare May 10, 2023 19:45
@smeijer smeijer merged commit dfed47c into smeijer:main May 10, 2023
@smeijer
Copy link
Owner

smeijer commented May 10, 2023

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants