Implement webhooks model #1836
Merged
Implement webhooks model #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased on |
Azquelt
changed the title
|
The annotation has been removed from the upstream PR. Removed the implementation here to match. |
MikeEdgar
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebhookIOclass.webhooksproperty just holds aMap<String, PathItem>@Webhookannotation represents one entry in that map. Since the value is aPathItem, I added it toPathItemIO. I could make a new IO class for it instead, though there's no model object to read and write to JSON.Implements eclipse/microprofile-open-api#612
In order to pass the TCK locally, I also have to merge in #1818 because that implements eclipse/microprofile-open-api#604 which has already been merged.