added VersionError

closes Automattic#1071
slouffka · Nov 13, 2012 · 620451f · 620451f
1 parent 6eecdad
commit 620451f
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 1 deletion.
diff --git a/lib/errors/version.js b/lib/errors/version.js
@@ -0,0  1,31 @@
 
 /*!
  * Module dependencies.
  */
 
 var MongooseError = require('../error');
 
 /**
  * Version Error constructor.
  *
  * @inherits MongooseError
  * @api private
  */
 
 function VersionError () {
   MongooseError.call(this, 'No matching document found.');
   Error.captureStackTrace(this, arguments.callee);
   this.name = 'VersionError';
 };
 
 /*!
  * Inherits from MongooseError.
  */
 
 VersionError.prototype.__proto__ = MongooseError.prototype;
 
 /*!
  * exports
  */
 
 module.exports = VersionError;
diff --git a/lib/model.js b/lib/model.js
@@ -6,6  6,7 @@ var Document = require('./document')
   , MongooseArray = require('./types/array')
   , MongooseBuffer = require('./types/buffer')
   , MongooseError = require('./error')
   , VersionError = require('./errors/version')
   , Query = require('./query')
   , Schema = require('./schema')
   , utils = require('./utils')
@@ -321,7  322,7 @@ function handleSave (promise, self) {
         }
       } else {
         // the update failed. pass an error back
-        promise.error(new Error('No matching document found.'));
         promise.error(new VersionError);
         promise = self = null;
         return;
       }

diff --git a/test/versioning.test.js b/test/versioning.test.js
@@ -227,6  227,7 @@ describe('versioning', function(){
     }
 
     function test12 (err, a, b) {
       assert.ok(err instanceof VersionError);
       assert.ok(/No matching document/.test(err), 'changes to b should not be applied');
       assert.equal(5, a.comments.length);