live-preview: Fix size being displayed wrongly #6134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
approved these changes
Sep 14, 2024
Stop abusing the init callback, abuse the changed callback instead ;-) Also merge the initial size calculation into one place. This fixes the preview showing the wrong sizes. It does introduce a bit of flicker though as the UI is rendered in the wrong state once and then immediently corrects itself. That is annoying, but strictly better than staying in the wrong state till the user does something. Closes: slint-ui#5954
hunger
force-pushed
the
tobias/push-oxplzuwuuwrl
branch
from
269a150 to
b74554c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop abusing the init callback, abuse the changed callback instead ;-)
Also merge the initial size calculation into one place. This fixes the preview showing the wrong sizes. It does introduce a bit of flicker though as the UI is rendered in the wrong state once and then immediently corrects itself.
That is annoying, but strictly better than staying in the wrong state till the user does something.
Closes: #5954